Commit 347a5c73 authored Mar 01, 2017 by Suraj Jitindar Singh Committed by David Gibson Mar 03, 2017

target/ppc: Add execute permission checking to access authority check



Basic storage protection defines various access authority permissions
based on a slb storage key and pte pp value pair. This access authority
defines read, write and execute permissions however currently we only
use this to control read and write permissions and ignore the execute
control.

Fix the code to allow execute permissions based on the key-pp value pair.
Execute is allowed under the same conditions which enable reads.
(i.e. read permission -> execute permission)

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

parent a6152b52

target/ppc/mmu-hash64.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -308,28 +308,27 @@ static int ppc_hash64_pte_prot(PowerPCCPU *cpu,
		case 0x0:
		case 0x1:
		case 0x2:
		prot = PAGE_READ \| PAGE_WRITE;
		prot = PAGE_READ \| PAGE_WRITE \| PAGE_EXEC;
		break;

		case 0x3:
		case 0x6:
		prot = PAGE_READ;
		prot = PAGE_READ \| PAGE_EXEC;
		break;
		}
		} else {
		switch (pp) {
		case 0x0:
		case 0x6:
		prot = 0;
		break;

		case 0x1:
		case 0x3:
		prot = PAGE_READ;
		prot = PAGE_READ \| PAGE_EXEC;
		break;

		case 0x2:
		prot = PAGE_READ \| PAGE_WRITE;
		prot = PAGE_READ \| PAGE_WRITE \| PAGE_EXEC;
		break;
		}
		}