Commit 345f1ab9 authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts 



Let's stop the timer and delete any pending CKC IRQ before doing
anything else.

While at it, add a comment why the check for ckc == -1ULL is needed.

Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20180627134410.4901-7-david@redhat.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent 7de3b1cd

target/s390x/misc_helper.c

+7 −0
Original line number Diff line number Diff line
@@ -154,6 +154,13 @@ void HELPER(sckc)(CPUS390XState *env, uint64_t time) 
{

    S390TODState *td = s390_get_todstate();



    /* stop the timer and remove pending CKC IRQs */

    timer_del(env->tod_timer);

    qemu_mutex_lock_iothread();

    env->pending_int &= ~INTERRUPT_EXT_CLOCK_COMPARATOR;

    qemu_mutex_unlock_iothread();



    /* the tod has to exceed the ckc, this can never happen if ckc is all 1's */

    if (time == -1ULL) {

        return;

    }