Commit 34525595 authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by David Gibson
Browse files

target/ppc: Add basic support for "new format" HPTE as found on POWER9 



POWER9 (arch v3) slightly changes the HPTE format. The B bits move
from the first to the second half of the HPTE, and the AVPN/ARPN
are slightly shorter.

However, under SPAPR, the hypercalls still take the old format
(and probably will for the foreseable future).

The simplest way to support this is thus to convert the HPTEs from
new to old format when reading them if the MMU model is v3 and there
is no virtual hypervisor, leaving the rest of the code unchanged.

Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Message-Id: <20190215170029.15641-8-clg@kaod.org>
[dwg: Moved function to .c since there was no real need for it in the .h]
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 3054b0ca

target/ppc/mmu-hash64.c

+17 −0
Original line number Diff line number Diff line
@@ -490,6 +490,18 @@ static unsigned hpte_page_shift(const PPCHash64SegmentPageSizes *sps, 
    return 0; /* Bad page size encoding */

}



static void ppc64_v3_new_to_old_hpte(target_ulong *pte0, target_ulong *pte1)

{

    /* Insert B into pte0 */

    *pte0 = (*pte0 & HPTE64_V_COMMON_BITS) |

            ((*pte1 & HPTE64_R_3_0_SSIZE_MASK) <<

             (HPTE64_V_SSIZE_SHIFT - HPTE64_R_3_0_SSIZE_SHIFT));



    /* Remove B from pte1 */

    *pte1 = *pte1 & ~HPTE64_R_3_0_SSIZE_MASK;

}





static hwaddr ppc_hash64_pteg_search(PowerPCCPU *cpu, hwaddr hash,

                                     const PPCHash64SegmentPageSizes *sps,

                                     target_ulong ptem,
@@ -515,6 +527,11 @@ static hwaddr ppc_hash64_pteg_search(PowerPCCPU *cpu, hwaddr hash, 
        smp_rmb();

        pte1 = ppc_hash64_hpte1(cpu, pteg, i);



        /* Convert format if necessary */

        if (cpu->env.mmu_model == POWERPC_MMU_3_00 && !cpu->vhyp) {

            ppc64_v3_new_to_old_hpte(&pte0, &pte1);

        }



        /* This compares V, B, H (secondary) and the AVPN */

        if (HPTE64_V_COMPARE(pte0, ptem)) {

            *pshift = hpte_page_shift(sps, pte0, pte1);

target/ppc/mmu-hash64.h

+5 −0
Original line number Diff line number Diff line
@@ -102,6 +102,11 @@ void ppc_hash64_filter_pagesizes(PowerPCCPU *cpu, 
#define HPTE64_V_1TB_SEG        0x4000000000000000ULL

#define HPTE64_V_VRMA_MASK      0x4001ffffff000000ULL



/* Format changes for ARCH v3 */

#define HPTE64_V_COMMON_BITS    0x000fffffffffffffULL

#define HPTE64_R_3_0_SSIZE_SHIFT 58

#define HPTE64_R_3_0_SSIZE_MASK (3ULL << HPTE64_R_3_0_SSIZE_SHIFT)



static inline hwaddr ppc_hash64_hpt_base(PowerPCCPU *cpu)

{

    if (cpu->vhyp) {