Commit 33badfd1 authored by Daniel P. Berrangé's avatar Daniel P. Berrangé
Browse files

io: use case insensitive check for Connection & Upgrade websock headers 



When checking the value of the Connection and Upgrade HTTP headers
the websock RFC (6455) requires the comparison to be case insensitive.
The Connection value should be an exact match not a substring.

Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
parent 3a3f8705

io/channel-websock.c

+2 −2
Original line number Diff line number Diff line
@@ -431,12 +431,12 @@ static void qio_channel_websock_handshake_process(QIOChannelWebsock *ioc, 
        goto bad_request;

    }



    if (!g_strrstr(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE)) {

    if (strcasecmp(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE) != 0) {

        error_setg(errp, "No connection upgrade requested '%s'", connection);

        goto bad_request;

    }



    if (!g_str_equal(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET)) {

    if (strcasecmp(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET) != 0) {

        error_setg(errp, "Incorrect upgrade method '%s'", upgrade);

        goto bad_request;

    }