Commit 32a2003a authored by Alex Barcelo's avatar Alex Barcelo Committed by Alexander Graf
Browse files

Bad zero comparison for sas_ss_flags on powerpc 



All architectures work the same way, and all check for sas_ss_flags ==
0. The powerpc lines are wrong, and do the check the other way round
(it's a qemu internal check, which is done wrong only for this
architecture, it's more a typo than a bug). It's NOT ppc specific,
it's POSIX standard (sigaltstack) and qemu internal.

I have a test source that I will send in a follow-up (it's longer than
I would have wished, I'm sure that a better test case can be written
if needed)

Signed-off-by: default avatarAlex Barcelo <abarcelo@ac.upc.edu>
Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
parent ae7d54d4

linux-user/signal.c

+1 −1
Original line number Diff line number Diff line
@@ -4118,7 +4118,7 @@ static target_ulong get_sigframe(struct target_sigaction *ka, 
    oldsp = env->gpr[1];



    if ((ka->sa_flags & TARGET_SA_ONSTACK) &&

        (sas_ss_flags(oldsp))) {

        (sas_ss_flags(oldsp) == 0)) {

        oldsp = (target_sigaltstack_used.ss_sp

                 + target_sigaltstack_used.ss_size);

    }