Commit 325837ca authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

spapr_drc: abort if object_property_add_child() fails 



object_property_add_child() can only fail in two cases:
- the child already has a parent, which shouldn't happen since the DRC was
  allocated a few lines above
- the parent already has a child with the same name, which would mean the
  caller tries to create a DRC that already exists

In both case, this is a QEMU bug and we should abort.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent b8af5b2d

hw/ppc/spapr_drc.c

+1 −1
Original line number Diff line number Diff line
@@ -541,7 +541,7 @@ sPAPRDRConnector *spapr_dr_connector_new(Object *owner, const char *type, 
    drc->owner = owner;

    prop_name = g_strdup_printf("dr-connector[%"PRIu32"]",

                                spapr_drc_index(drc));

    object_property_add_child(owner, prop_name, OBJECT(drc), NULL);

    object_property_add_child(owner, prop_name, OBJECT(drc), &error_abort);

    object_property_set_bool(OBJECT(drc), true, "realized", NULL);

    g_free(prop_name);