Commit 31d0f80f authored by Markus Armbruster's avatar Markus Armbruster Committed by Amit Shah
Browse files

virtio-serial: Drop useless property is_console 



All you could ever achieve with it is break stuff, so removing it
should be safe.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
parent 2a3d57ce

hw/virtio-console.c

+0 −2
Original line number Diff line number Diff line
@@ -91,7 +91,6 @@ static int virtconsole_initfn(VirtIOSerialPort *port) 
{

    VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);



    port->is_console_dummy = true;

    return generic_port_init(vcon, port);

}
@@ -117,7 +116,6 @@ static VirtIOSerialPortInfo virtconsole_info = { 
    .init          = virtconsole_initfn,

    .exit          = virtconsole_exitfn,

    .qdev.props = (Property[]) {

        DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console_dummy, 1),

        DEFINE_PROP_UINT32("nr", VirtConsole, port.id, VIRTIO_CONSOLE_BAD_ID),

        DEFINE_PROP_CHR("chardev", VirtConsole, chr),

        DEFINE_PROP_STRING("name", VirtConsole, port.name),

hw/virtio-serial.h

+0 −3
Original line number Diff line number Diff line
@@ -124,9 +124,6 @@ struct VirtIOSerialPort { 
     */

    QEMUBH *bh;



    /* For property backward compatibility, not used otherwise */

    uint8_t is_console_dummy;



    /* Is the corresponding guest device open? */

    bool guest_connected;

    /* Is this device open for IO on the host? */