Commit 3119154d authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Peter Maydell
Browse files

target/ppc: Fix TCG temporary leaks in gen_slbia() 

This fixes:

  $ qemu-system-ppc64 \
  -machine pseries-4.1 -cpu power9 \
  -smp 4 -m 12G -accel tcg ...
  ...
  Quiescing Open Firmware ...
  Booting Linux via __start() @ 0x0000000002000000 ...
  Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
  Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
  Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries

[*] https://www.mail-archive.com/qemu-discuss@nongnu.org/msg05400.html



Fixes: 0418bf78 ("Fix ISA v3.0 (POWER9) slbia implementation")
Reported-by: default avatarDennis Clarke <dclarke@blastwave.org>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarNicholas Piggin <npiggin@gmail.com>
Reviewed-by: default avatarCédric Le Goater <clg@kaod.org>
Message-id: 20200417090749.14310-1-f4bug@amsat.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 5b4273e4

target/ppc/translate.c

+1 −0
Original line number Diff line number Diff line
@@ -5011,6 +5011,7 @@ static void gen_slbia(DisasContext *ctx) 
    CHK_SV;



    gen_helper_slbia(cpu_env, t0);

    tcg_temp_free_i32(t0);

#endif /* defined(CONFIG_USER_ONLY) */

}