Commit 2fe5a9f7 authored by Ulrich Obergfell's avatar Ulrich Obergfell Committed by Paolo Bonzini
Browse files

scsi-disk: fix bug in scsi_block_new_request() introduced by commit 137745c5 



This patch fixes a bug in scsi_block_new_request() that was introduced
by commit 137745c5. If the host cache
is used - i.e. if BDRV_O_NOCACHE is _not_ set - the 'break' statement
needs to be executed to 'fall back' to SG_IO.

Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarUlrich Obergfell <uobergfe@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 4525c133

hw/scsi/scsi-disk.c

+1 −1
Original line number Diff line number Diff line
@@ -2526,7 +2526,7 @@ static SCSIRequest *scsi_block_new_request(SCSIDevice *d, uint32_t tag, 
	 * ones (such as WRITE SAME or EXTENDED COPY, etc.).  So, without

	 * O_DIRECT everything must go through SG_IO.

         */

        if (bdrv_get_flags(s->qdev.conf.bs) & BDRV_O_NOCACHE) {

        if (!(bdrv_get_flags(s->qdev.conf.bs) & BDRV_O_NOCACHE)) {

            break;

        }