Commit 2f311075 authored by Richard Henderson's avatar Richard Henderson Committed by Alex Bennée
Browse files

softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal 



All other calls to normalize*Subnormal detect zero input before
the call -- this is the only outlier.  This case can happen with
+0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of
the correct sign.

Reported-by: Coverity (CID 1421991)
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Message-Id: <20200327232042.10008-1-richard.henderson@linaro.org>
Message-Id: <20200403191150.863-8-alex.bennee@linaro.org>
parent 076b2fad

fpu/softfloat.c

+3 −0
Original line number Diff line number Diff line
@@ -5856,6 +5856,9 @@ static floatx80 addFloatx80Sigs(floatx80 a, floatx80 b, flag zSign, 
        zSig1 = 0;

        zSig0 = aSig + bSig;

        if ( aExp == 0 ) {

            if (zSig0 == 0) {

                return packFloatx80(zSign, 0, 0);

            }

            normalizeFloatx80Subnormal( zSig0, &zExp, &zSig0 );

            goto roundAndPack;

        }