Commit 2e2f4ade authored by Blue Swirl's avatar Blue Swirl
Browse files

Sparc: avoid AREG0 for float and VIS ops



Make floating point and VIS ops take a parameter for CPUState instead
of relying on global env.

Reviewed-by: default avatarRichard Henderson <rth@twiddle.net>
Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
parent 1bccec25
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ tcg/tcg.o: cpu.h

# HELPER_CFLAGS is used for all the code compiled with static register
# variables
op_helper.o fop_helper.o vis_helper.o user-exec.o: QEMU_CFLAGS += $(HELPER_CFLAGS)
op_helper.o user-exec.o: QEMU_CFLAGS += $(HELPER_CFLAGS)

# Note: this is a workaround. The real fix is to avoid compiling
# cpu_signal_handler() in user-exec.c.
+35 −35
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@
 */

#include "cpu.h"
#include "dyngen-exec.h"
#include "helper.h"

#define DT0 (env->dt0)
@@ -26,10 +25,11 @@
#define QT0 (env->qt0)
#define QT1 (env->qt1)

#define F_HELPER(name, p) void helper_f##name##p(void)
#define F_HELPER(name, p) void helper_f##name##p(CPUState *env)

#define F_BINOP(name)                                           \
    float32 helper_f ## name ## s (float32 src1, float32 src2)  \
    float32 helper_f ## name ## s (CPUState * env, float32 src1,\
                                   float32 src2)                \
    {                                                           \
        return float32_ ## name (src1, src2, &env->fp_status);  \
    }                                                           \
@@ -48,14 +48,14 @@ F_BINOP(mul);
F_BINOP(div);
#undef F_BINOP

void helper_fsmuld(float32 src1, float32 src2)
void helper_fsmuld(CPUState *env, float32 src1, float32 src2)
{
    DT0 = float64_mul(float32_to_float64(src1, &env->fp_status),
                      float32_to_float64(src2, &env->fp_status),
                      &env->fp_status);
}

void helper_fdmulq(void)
void helper_fdmulq(CPUState *env)
{
    QT0 = float128_mul(float64_to_float128(DT0, &env->fp_status),
                       float64_to_float128(DT1, &env->fp_status),
@@ -80,23 +80,23 @@ F_HELPER(neg, q)
#endif

/* Integer to float conversion.  */
float32 helper_fitos(int32_t src)
float32 helper_fitos(CPUState *env, int32_t src)
{
    return int32_to_float32(src, &env->fp_status);
}

void helper_fitod(int32_t src)
void helper_fitod(CPUState *env, int32_t src)
{
    DT0 = int32_to_float64(src, &env->fp_status);
}

void helper_fitoq(int32_t src)
void helper_fitoq(CPUState *env, int32_t src)
{
    QT0 = int32_to_float128(src, &env->fp_status);
}

#ifdef TARGET_SPARC64
float32 helper_fxtos(void)
float32 helper_fxtos(CPUState *env)
{
    return int64_to_float32(*((int64_t *)&DT1), &env->fp_status);
}
@@ -114,64 +114,64 @@ F_HELPER(xto, q)
#undef F_HELPER

/* floating point conversion */
float32 helper_fdtos(void)
float32 helper_fdtos(CPUState *env)
{
    return float64_to_float32(DT1, &env->fp_status);
}

void helper_fstod(float32 src)
void helper_fstod(CPUState *env, float32 src)
{
    DT0 = float32_to_float64(src, &env->fp_status);
}

float32 helper_fqtos(void)
float32 helper_fqtos(CPUState *env)
{
    return float128_to_float32(QT1, &env->fp_status);
}

void helper_fstoq(float32 src)
void helper_fstoq(CPUState *env, float32 src)
{
    QT0 = float32_to_float128(src, &env->fp_status);
}

void helper_fqtod(void)
void helper_fqtod(CPUState *env)
{
    DT0 = float128_to_float64(QT1, &env->fp_status);
}

void helper_fdtoq(void)
void helper_fdtoq(CPUState *env)
{
    QT0 = float64_to_float128(DT1, &env->fp_status);
}

/* Float to integer conversion.  */
int32_t helper_fstoi(float32 src)
int32_t helper_fstoi(CPUState *env, float32 src)
{
    return float32_to_int32_round_to_zero(src, &env->fp_status);
}

int32_t helper_fdtoi(void)
int32_t helper_fdtoi(CPUState *env)
{
    return float64_to_int32_round_to_zero(DT1, &env->fp_status);
}

int32_t helper_fqtoi(void)
int32_t helper_fqtoi(CPUState *env)
{
    return float128_to_int32_round_to_zero(QT1, &env->fp_status);
}

#ifdef TARGET_SPARC64
void helper_fstox(float32 src)
void helper_fstox(CPUState *env, float32 src)
{
    *((int64_t *)&DT0) = float32_to_int64_round_to_zero(src, &env->fp_status);
}

void helper_fdtox(void)
void helper_fdtox(CPUState *env)
{
    *((int64_t *)&DT0) = float64_to_int64_round_to_zero(DT1, &env->fp_status);
}

void helper_fqtox(void)
void helper_fqtox(CPUState *env)
{
    *((int64_t *)&DT0) = float128_to_int64_round_to_zero(QT1, &env->fp_status);
}
@@ -183,34 +183,34 @@ float32 helper_fabss(float32 src)
}

#ifdef TARGET_SPARC64
void helper_fabsd(void)
void helper_fabsd(CPUState *env)
{
    DT0 = float64_abs(DT1);
}

void helper_fabsq(void)
void helper_fabsq(CPUState *env)
{
    QT0 = float128_abs(QT1);
}
#endif

float32 helper_fsqrts(float32 src)
float32 helper_fsqrts(CPUState *env, float32 src)
{
    return float32_sqrt(src, &env->fp_status);
}

void helper_fsqrtd(void)
void helper_fsqrtd(CPUState *env)
{
    DT0 = float64_sqrt(DT1, &env->fp_status);
}

void helper_fsqrtq(void)
void helper_fsqrtq(CPUState *env)
{
    QT0 = float128_sqrt(QT1, &env->fp_status);
}

#define GEN_FCMP(name, size, reg1, reg2, FS, E)                         \
    void glue(helper_, name) (void)                                     \
    void glue(helper_, name) (CPUState *env)                            \
    {                                                                   \
        env->fsr &= FSR_FTT_NMASK;                                      \
        if (E && (glue(size, _is_any_nan)(reg1) ||                      \
@@ -246,7 +246,7 @@ void helper_fsqrtq(void)
        }                                                               \
    }
#define GEN_FCMPS(name, size, FS, E)                                    \
    void glue(helper_, name)(float32 src1, float32 src2)                \
    void glue(helper_, name)(CPUState *env, float32 src1, float32 src2) \
    {                                                                   \
        env->fsr &= FSR_FTT_NMASK;                                      \
        if (E && (glue(size, _is_any_nan)(src1) ||                      \
@@ -318,7 +318,7 @@ GEN_FCMP(fcmpeq_fcc3, float128, QT0, QT1, 26, 1);
#endif
#undef GEN_FCMPS

void helper_check_ieee_exceptions(void)
void helper_check_ieee_exceptions(CPUState *env)
{
    target_ulong status;

@@ -352,12 +352,12 @@ void helper_check_ieee_exceptions(void)
    }
}

void helper_clear_float_exceptions(void)
void helper_clear_float_exceptions(CPUState *env)
{
    set_float_exception_flags(0, &env->fp_status);
}

static inline void set_fsr(void)
static inline void set_fsr(CPUState *env)
{
    int rnd_mode;

@@ -379,16 +379,16 @@ static inline void set_fsr(void)
    set_float_rounding_mode(rnd_mode, &env->fp_status);
}

void helper_ldfsr(uint32_t new_fsr)
void helper_ldfsr(CPUState *env, uint32_t new_fsr)
{
    env->fsr = (new_fsr & FSR_LDFSR_MASK) | (env->fsr & FSR_LDFSR_OLDMASK);
    set_fsr();
    set_fsr(env);
}

#ifdef TARGET_SPARC64
void helper_ldxfsr(uint64_t new_fsr)
void helper_ldxfsr(CPUState *env, uint64_t new_fsr)
{
    env->fsr = (new_fsr & FSR_LDXFSR_MASK) | (env->fsr & FSR_LDXFSR_OLDMASK);
    set_fsr();
    set_fsr(env);
}
#endif
+86 −86
Original line number Diff line number Diff line
@@ -16,8 +16,8 @@ DEF_HELPER_0(rdccr, tl)
DEF_HELPER_1(wrccr, void, tl)
DEF_HELPER_0(rdcwp, tl)
DEF_HELPER_1(wrcwp, void, tl)
DEF_HELPER_2(array8, tl, tl, tl)
DEF_HELPER_2(alignaddr, tl, tl, tl)
DEF_HELPER_3(array8, tl, env, tl, tl)
DEF_HELPER_3(alignaddr, tl, env, tl, tl)
DEF_HELPER_1(popc, tl, tl)
DEF_HELPER_3(ldda_asi, void, tl, int, int)
DEF_HELPER_4(ldf_asi, void, tl, int, int, int)
@@ -47,116 +47,116 @@ DEF_HELPER_2(stqf, void, tl, int)
DEF_HELPER_4(ld_asi, i64, tl, int, int, int)
DEF_HELPER_4(st_asi, void, tl, i64, int, int)
#endif
DEF_HELPER_1(ldfsr, void, i32)
DEF_HELPER_0(check_ieee_exceptions, void)
DEF_HELPER_0(clear_float_exceptions, void)
DEF_HELPER_2(ldfsr, void, env, i32)
DEF_HELPER_1(check_ieee_exceptions, void, env)
DEF_HELPER_1(clear_float_exceptions, void, env)
DEF_HELPER_1(fabss, f32, f32)
DEF_HELPER_1(fsqrts, f32, f32)
DEF_HELPER_0(fsqrtd, void)
DEF_HELPER_2(fcmps, void, f32, f32)
DEF_HELPER_0(fcmpd, void)
DEF_HELPER_2(fcmpes, void, f32, f32)
DEF_HELPER_0(fcmped, void)
DEF_HELPER_0(fsqrtq, void)
DEF_HELPER_0(fcmpq, void)
DEF_HELPER_0(fcmpeq, void)
DEF_HELPER_2(fsqrts, f32, env, f32)
DEF_HELPER_1(fsqrtd, void, env)
DEF_HELPER_3(fcmps, void, env, f32, f32)
DEF_HELPER_1(fcmpd, void, env)
DEF_HELPER_3(fcmpes, void, env, f32, f32)
DEF_HELPER_1(fcmped, void, env)
DEF_HELPER_1(fsqrtq, void, env)
DEF_HELPER_1(fcmpq, void, env)
DEF_HELPER_1(fcmpeq, void, env)
#ifdef TARGET_SPARC64
DEF_HELPER_1(ldxfsr, void, i64)
DEF_HELPER_0(fabsd, void)
DEF_HELPER_2(fcmps_fcc1, void, f32, f32)
DEF_HELPER_2(fcmps_fcc2, void, f32, f32)
DEF_HELPER_2(fcmps_fcc3, void, f32, f32)
DEF_HELPER_0(fcmpd_fcc1, void)
DEF_HELPER_0(fcmpd_fcc2, void)
DEF_HELPER_0(fcmpd_fcc3, void)
DEF_HELPER_2(fcmpes_fcc1, void, f32, f32)
DEF_HELPER_2(fcmpes_fcc2, void, f32, f32)
DEF_HELPER_2(fcmpes_fcc3, void, f32, f32)
DEF_HELPER_0(fcmped_fcc1, void)
DEF_HELPER_0(fcmped_fcc2, void)
DEF_HELPER_0(fcmped_fcc3, void)
DEF_HELPER_0(fabsq, void)
DEF_HELPER_0(fcmpq_fcc1, void)
DEF_HELPER_0(fcmpq_fcc2, void)
DEF_HELPER_0(fcmpq_fcc3, void)
DEF_HELPER_0(fcmpeq_fcc1, void)
DEF_HELPER_0(fcmpeq_fcc2, void)
DEF_HELPER_0(fcmpeq_fcc3, void)
DEF_HELPER_2(ldxfsr, void, env, i64)
DEF_HELPER_1(fabsd, void, env)
DEF_HELPER_3(fcmps_fcc1, void, env, f32, f32)
DEF_HELPER_3(fcmps_fcc2, void, env, f32, f32)
DEF_HELPER_3(fcmps_fcc3, void, env, f32, f32)
DEF_HELPER_1(fcmpd_fcc1, void, env)
DEF_HELPER_1(fcmpd_fcc2, void, env)
DEF_HELPER_1(fcmpd_fcc3, void, env)
DEF_HELPER_3(fcmpes_fcc1, void, env, f32, f32)
DEF_HELPER_3(fcmpes_fcc2, void, env, f32, f32)
DEF_HELPER_3(fcmpes_fcc3, void, env, f32, f32)
DEF_HELPER_1(fcmped_fcc1, void, env)
DEF_HELPER_1(fcmped_fcc2, void, env)
DEF_HELPER_1(fcmped_fcc3, void, env)
DEF_HELPER_1(fabsq, void, env)
DEF_HELPER_1(fcmpq_fcc1, void, env)
DEF_HELPER_1(fcmpq_fcc2, void, env)
DEF_HELPER_1(fcmpq_fcc3, void, env)
DEF_HELPER_1(fcmpeq_fcc1, void, env)
DEF_HELPER_1(fcmpeq_fcc2, void, env)
DEF_HELPER_1(fcmpeq_fcc3, void, env)
#endif
DEF_HELPER_2(raise_exception, void, env, int)
DEF_HELPER_0(shutdown, void)
#define F_HELPER_0_0(name) DEF_HELPER_0(f ## name, void)
#define F_HELPER_DQ_0_0(name)                   \
    F_HELPER_0_0(name ## d);                    \
    F_HELPER_0_0(name ## q)
#define F_HELPER_0_1(name) DEF_HELPER_1(f ## name, void, env)
#define F_HELPER_DQ_0_1(name)                   \
    F_HELPER_0_1(name ## d);                    \
    F_HELPER_0_1(name ## q)

F_HELPER_DQ_0_0(add);
F_HELPER_DQ_0_0(sub);
F_HELPER_DQ_0_0(mul);
F_HELPER_DQ_0_0(div);
F_HELPER_DQ_0_1(add);
F_HELPER_DQ_0_1(sub);
F_HELPER_DQ_0_1(mul);
F_HELPER_DQ_0_1(div);

DEF_HELPER_2(fadds, f32, f32, f32)
DEF_HELPER_2(fsubs, f32, f32, f32)
DEF_HELPER_2(fmuls, f32, f32, f32)
DEF_HELPER_2(fdivs, f32, f32, f32)
DEF_HELPER_3(fadds, f32, env, f32, f32)
DEF_HELPER_3(fsubs, f32, env, f32, f32)
DEF_HELPER_3(fmuls, f32, env, f32, f32)
DEF_HELPER_3(fdivs, f32, env, f32, f32)

DEF_HELPER_2(fsmuld, void, f32, f32)
F_HELPER_0_0(dmulq);
DEF_HELPER_3(fsmuld, void, env, f32, f32)
F_HELPER_0_1(dmulq);

DEF_HELPER_1(fnegs, f32, f32)
DEF_HELPER_1(fitod, void, s32)
DEF_HELPER_1(fitoq, void, s32)
DEF_HELPER_2(fitod, void, env, s32)
DEF_HELPER_2(fitoq, void, env, s32)

DEF_HELPER_1(fitos, f32, s32)
DEF_HELPER_2(fitos, f32, env, s32)

#ifdef TARGET_SPARC64
DEF_HELPER_0(fnegd, void)
DEF_HELPER_0(fnegq, void)
DEF_HELPER_0(fxtos, i32)
F_HELPER_DQ_0_0(xto);
DEF_HELPER_1(fnegd, void, env)
DEF_HELPER_1(fnegq, void, env)
DEF_HELPER_1(fxtos, i32, env)
F_HELPER_DQ_0_1(xto);
#endif
DEF_HELPER_0(fdtos, f32)
DEF_HELPER_1(fstod, void, f32)
DEF_HELPER_0(fqtos, f32)
DEF_HELPER_1(fstoq, void, f32)
F_HELPER_0_0(qtod);
F_HELPER_0_0(dtoq);
DEF_HELPER_1(fstoi, s32, f32)
DEF_HELPER_0(fdtoi, s32)
DEF_HELPER_0(fqtoi, s32)
DEF_HELPER_1(fdtos, f32, env)
DEF_HELPER_2(fstod, void, env, f32)
DEF_HELPER_1(fqtos, f32, env)
DEF_HELPER_2(fstoq, void, env, f32)
F_HELPER_0_1(qtod);
F_HELPER_0_1(dtoq);
DEF_HELPER_2(fstoi, s32, env, f32)
DEF_HELPER_1(fdtoi, s32, env)
DEF_HELPER_1(fqtoi, s32, env)
#ifdef TARGET_SPARC64
DEF_HELPER_1(fstox, void, i32)
F_HELPER_0_0(dtox);
F_HELPER_0_0(qtox);
F_HELPER_0_0(aligndata);
DEF_HELPER_2(fstox, void, env, i32)
F_HELPER_0_1(dtox);
F_HELPER_0_1(qtox);
F_HELPER_0_1(aligndata);

F_HELPER_0_0(pmerge);
F_HELPER_0_0(mul8x16);
F_HELPER_0_0(mul8x16al);
F_HELPER_0_0(mul8x16au);
F_HELPER_0_0(mul8sux16);
F_HELPER_0_0(mul8ulx16);
F_HELPER_0_0(muld8sux16);
F_HELPER_0_0(muld8ulx16);
F_HELPER_0_0(expand);
F_HELPER_0_1(pmerge);
F_HELPER_0_1(mul8x16);
F_HELPER_0_1(mul8x16al);
F_HELPER_0_1(mul8x16au);
F_HELPER_0_1(mul8sux16);
F_HELPER_0_1(mul8ulx16);
F_HELPER_0_1(muld8sux16);
F_HELPER_0_1(muld8ulx16);
F_HELPER_0_1(expand);
#define VIS_HELPER(name)                                 \
    F_HELPER_0_0(name##16);                              \
    DEF_HELPER_2(f ## name ## 16s, i32, i32, i32) \
    F_HELPER_0_0(name##32);                              \
    DEF_HELPER_2(f ## name ## 32s, i32, i32, i32)
    F_HELPER_0_1(name##16);                              \
    DEF_HELPER_3(f ## name ## 16s, i32, env, i32, i32)   \
    F_HELPER_0_1(name##32);                              \
    DEF_HELPER_3(f ## name ## 32s, i32, env, i32, i32)

VIS_HELPER(padd);
VIS_HELPER(psub);
#define VIS_CMPHELPER(name)                              \
    DEF_HELPER_0(f##name##16, i64);                      \
    DEF_HELPER_0(f##name##32, i64)
    DEF_HELPER_1(f##name##16, i64, env);                 \
    DEF_HELPER_1(f##name##32, i64, env)
VIS_CMPHELPER(cmpgt);
VIS_CMPHELPER(cmpeq);
VIS_CMPHELPER(cmple);
VIS_CMPHELPER(cmpne);
#endif
#undef F_HELPER_0_0
#undef F_HELPER_DQ_0_0
#undef F_HELPER_0_1
#undef F_HELPER_DQ_0_1
#undef VIS_HELPER
#undef VIS_CMPHELPER
DEF_HELPER_0(compute_psr, void);
+137 −133

File changed.

Preview size limit exceeded, changes collapsed.

+22 −19
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@
 */

#include "cpu.h"
#include "dyngen-exec.h"
#include "helper.h"

#define DT0 (env->dt0)
@@ -34,7 +33,8 @@
#define GET_FIELD_SP(X, FROM, TO)               \
    GET_FIELD(X, 63 - (TO), 63 - (FROM))

target_ulong helper_array8(target_ulong pixel_addr, target_ulong cubesize)
target_ulong helper_array8(CPUState *env, target_ulong pixel_addr,
                           target_ulong cubesize)
{
    return (GET_FIELD_SP(pixel_addr, 60, 63) << (17 + 2 * cubesize)) |
        (GET_FIELD_SP(pixel_addr, 39, 39 + cubesize - 1) << (17 + cubesize)) |
@@ -47,7 +47,8 @@ target_ulong helper_array8(target_ulong pixel_addr, target_ulong cubesize)
        GET_FIELD_SP(pixel_addr, 11, 12);
}

target_ulong helper_alignaddr(target_ulong addr, target_ulong offset)
target_ulong helper_alignaddr(CPUState *env, target_ulong addr,
                              target_ulong offset)
{
    uint64_t tmp;

@@ -57,7 +58,7 @@ target_ulong helper_alignaddr(target_ulong addr, target_ulong offset)
    return tmp & ~7ULL;
}

void helper_faligndata(void)
void helper_faligndata(CPUState *env)
{
    uint64_t tmp;

@@ -101,7 +102,7 @@ typedef union {
    float32 f;
} VIS32;

void helper_fpmerge(void)
void helper_fpmerge(CPUState *env)
{
    VIS64 s, d;

@@ -121,7 +122,7 @@ void helper_fpmerge(void)
    DT0 = d.d;
}

void helper_fmul8x16(void)
void helper_fmul8x16(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -145,7 +146,7 @@ void helper_fmul8x16(void)
    DT0 = d.d;
}

void helper_fmul8x16al(void)
void helper_fmul8x16al(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -169,7 +170,7 @@ void helper_fmul8x16al(void)
    DT0 = d.d;
}

void helper_fmul8x16au(void)
void helper_fmul8x16au(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -193,7 +194,7 @@ void helper_fmul8x16au(void)
    DT0 = d.d;
}

void helper_fmul8sux16(void)
void helper_fmul8sux16(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -217,7 +218,7 @@ void helper_fmul8sux16(void)
    DT0 = d.d;
}

void helper_fmul8ulx16(void)
void helper_fmul8ulx16(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -241,7 +242,7 @@ void helper_fmul8ulx16(void)
    DT0 = d.d;
}

void helper_fmuld8sux16(void)
void helper_fmuld8sux16(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -264,7 +265,7 @@ void helper_fmuld8sux16(void)
    DT0 = d.d;
}

void helper_fmuld8ulx16(void)
void helper_fmuld8ulx16(CPUState *env)
{
    VIS64 s, d;
    uint32_t tmp;
@@ -287,7 +288,7 @@ void helper_fmuld8ulx16(void)
    DT0 = d.d;
}

void helper_fexpand(void)
void helper_fexpand(CPUState *env)
{
    VIS32 s;
    VIS64 d;
@@ -303,7 +304,7 @@ void helper_fexpand(void)
}

#define VIS_HELPER(name, F)                             \
    void name##16(void)                                 \
    void name##16(CPUState *env)                        \
    {                                                   \
        VIS64 s, d;                                     \
                                                        \
@@ -318,7 +319,8 @@ void helper_fexpand(void)
        DT0 = d.d;                                      \
    }                                                   \
                                                        \
    uint32_t name##16s(uint32_t src1, uint32_t src2)    \
    uint32_t name##16s(CPUState *env, uint32_t src1,    \
                       uint32_t src2)                   \
    {                                                   \
        VIS32 s, d;                                     \
                                                        \
@@ -331,7 +333,7 @@ void helper_fexpand(void)
        return d.l;                                     \
    }                                                   \
                                                        \
    void name##32(void)                                 \
    void name##32(CPUState *env)                        \
    {                                                   \
        VIS64 s, d;                                     \
                                                        \
@@ -344,7 +346,8 @@ void helper_fexpand(void)
        DT0 = d.d;                                      \
    }                                                   \
                                                        \
    uint32_t name##32s(uint32_t src1, uint32_t src2)    \
    uint32_t name##32s(CPUState *env, uint32_t src1,    \
                       uint32_t src2)                   \
    {                                                   \
        VIS32 s, d;                                     \
                                                        \
@@ -362,7 +365,7 @@ VIS_HELPER(helper_fpadd, FADD)
VIS_HELPER(helper_fpsub, FSUB)

#define VIS_CMPHELPER(name, F)                                    \
    uint64_t name##16(void)                                       \
    uint64_t name##16(CPUState *env)                              \
    {                                                             \
        VIS64 s, d;                                               \
                                                                  \
@@ -378,7 +381,7 @@ VIS_HELPER(helper_fpsub, FSUB)
        return d.ll;                                              \
    }                                                             \
                                                                  \
    uint64_t name##32(void)                                       \
    uint64_t name##32(CPUState *env)                              \
    {                                                             \
        VIS64 s, d;                                               \
                                                                  \