Commit 2e2db260 authored by Liam Merwick's avatar Liam Merwick Committed by Max Reitz
Browse files

qemu-img: assert block_job_get() does not return NULL in img_commit() 



Although the function block_job_get() can return NULL, it would be a
serious bug if it did so (because the job yields before executing anything
(if it started successfully); but otherwise, commit_active_start() would
have returned an error).  However, as a precaution, before dereferencing
the 'job' pointer in img_commit() assert it is not NULL.

Signed-off-by: default avatarLiam Merwick <Liam.Merwick@oracle.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 1541453919-25973-4-git-send-email-Liam.Merwick@oracle.com
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 602414d1

qemu-img.c

+1 −0
Original line number Diff line number Diff line
@@ -1029,6 +1029,7 @@ static int img_commit(int argc, char **argv) 
    }



    job = block_job_get("commit");

    assert(job);

    run_block_job(job, &local_err);

    if (local_err) {

        goto unref_backing;