Commit 2dc120be authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

vnc: fix double free issues 



Reported by Coverity: CID 1371242, 1371243, 1371244.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 1487682332-29154-1-git-send-email-kraxel@redhat.com
parent 8bf69b49

ui/vnc.c

+3 −0
Original line number Diff line number Diff line
@@ -3181,6 +3181,7 @@ static void vnc_display_close(VncDisplay *vd) 
    g_free(vd->lsock);

    g_free(vd->lsock_tag);

    vd->lsock = NULL;

    vd->lsock_tag = NULL;

    vd->nlsock = 0;



    for (i = 0; i < vd->nlwebsock; i++) {
@@ -3192,6 +3193,7 @@ static void vnc_display_close(VncDisplay *vd) 
    g_free(vd->lwebsock);

    g_free(vd->lwebsock_tag);

    vd->lwebsock = NULL;

    vd->lwebsock_tag = NULL;

    vd->nlwebsock = 0;



    vd->auth = VNC_AUTH_INVALID;
@@ -3204,6 +3206,7 @@ static void vnc_display_close(VncDisplay *vd) 
    vd->tlsaclname = NULL;

    if (vd->lock_key_sync) {

        qemu_remove_led_event_handler(vd->led);

        vd->led = NULL;

    }

}