Commit 2d9574bd authored by Li Qiang's avatar Li Qiang Committed by Laurent Vivier
Browse files

pci: msix: move 'MSIX_CAP_LENGTH' to header file 



'MSIX_CAP_LENGTH' is defined in two .c file. Move it
to hw/pci/msix.h file to reduce duplicated code.

CC: qemu-trivial@nongnu.org
Signed-off-by: default avatarLi Qiang <liq3ea@163.com>
Message-Id: <20190521151543.92274-5-liq3ea@163.com>
Acked-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent bf04ef35

hw/pci/msix.c

+0 −2
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ 
#include "qapi/error.h"

#include "trace.h"



#define MSIX_CAP_LENGTH 12



/* MSI enable bit and maskall bit are in byte 1 in FLAGS register */

#define MSIX_CONTROL_OFFSET (PCI_MSIX_FLAGS + 1)

#define MSIX_ENABLE_MASK (PCI_MSIX_FLAGS_ENABLE >> 8)

hw/vfio/pci.c

+0 −2
Original line number Diff line number Diff line
@@ -35,8 +35,6 @@ 
#include "trace.h"

#include "qapi/error.h"



#define MSIX_CAP_LENGTH 12



#define TYPE_VFIO_PCI "vfio-pci"

#define PCI_VFIO(obj)    OBJECT_CHECK(VFIOPCIDevice, obj, TYPE_VFIO_PCI)

include/hw/pci/msix.h

+2 −0
Original line number Diff line number Diff line
@@ -4,6 +4,8 @@ 
#include "qemu-common.h"

#include "hw/pci/pci.h"



#define MSIX_CAP_LENGTH 12



void msix_set_message(PCIDevice *dev, int vector, MSIMessage msg);

MSIMessage msix_get_message(PCIDevice *dev, unsigned int vector);

int msix_init(PCIDevice *dev, unsigned short nentries,