Commit 2d7799f2 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

qapi: add tests for string-based visitors 



Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent a020f980

.gitignore

+2 −0
Original line number Diff line number Diff line
@@ -44,6 +44,8 @@ QMP/qmp-commands.txt 
test-coroutine

test-qmp-input-visitor

test-qmp-output-visitor

test-string-input-visitor

test-string-output-visitor

fsdev/virtfs-proxy-helper.1

fsdev/virtfs-proxy-helper.pod

.gdbinit

test-string-input-visitor.c

0 → 100644
+195 −0
Original line number Diff line number Diff line 
/*

 * String Input Visitor unit-tests.

 *

 * Copyright (C) 2012 Red Hat Inc.

 *

 * Authors:

 *  Paolo Bonzini <pbonzini@redhat.com> (based on test-qmp-input-visitor)

 *

 * This work is licensed under the terms of the GNU GPL, version 2 or later.

 * See the COPYING file in the top-level directory.

 */



#include <glib.h>

#include <stdarg.h>



#include "qapi/string-input-visitor.h"

#include "test-qapi-types.h"

#include "test-qapi-visit.h"

#include "qemu-objects.h"



typedef struct TestInputVisitorData {

    StringInputVisitor *siv;

} TestInputVisitorData;



static void visitor_input_teardown(TestInputVisitorData *data,

                                   const void *unused)

{

    if (data->siv) {

        string_input_visitor_cleanup(data->siv);

        data->siv = NULL;

    }

}



/* This is provided instead of a test setup function so that the JSON

   string used by the tests are kept in the test functions (and not

   int main()) */

static

Visitor *visitor_input_test_init(TestInputVisitorData *data,

                                 const char *string)

{

    Visitor *v;



    data->siv = string_input_visitor_new(string);

    g_assert(data->siv != NULL);



    v = string_input_get_visitor(data->siv);

    g_assert(v != NULL);



    return v;

}



static void test_visitor_in_int(TestInputVisitorData *data,

                                const void *unused)

{

    int64_t res = 0, value = -42;

    Error *errp = NULL;

    Visitor *v;



    v = visitor_input_test_init(data, "-42");



    visit_type_int(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, value);

}



static void test_visitor_in_bool(TestInputVisitorData *data,

                                 const void *unused)

{

    Error *errp = NULL;

    bool res = false;

    Visitor *v;



    v = visitor_input_test_init(data, "true");



    visit_type_bool(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, true);

    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "yes");



    visit_type_bool(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, true);

    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "on");



    visit_type_bool(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, true);

    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "false");



    visit_type_bool(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, false);

    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "no");



    visit_type_bool(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, false);

    visitor_input_teardown(data, unused);



    v = visitor_input_test_init(data, "off");



    visit_type_bool(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpint(res, ==, false);

}



static void test_visitor_in_number(TestInputVisitorData *data,

                                   const void *unused)

{

    double res = 0, value = 3.14;

    Error *errp = NULL;

    Visitor *v;



    v = visitor_input_test_init(data, "3.14");



    visit_type_number(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpfloat(res, ==, value);

}



static void test_visitor_in_string(TestInputVisitorData *data,

                                   const void *unused)

{

    char *res = NULL, *value = (char *) "Q E M U";

    Error *errp = NULL;

    Visitor *v;



    v = visitor_input_test_init(data, value);



    visit_type_str(v, &res, NULL, &errp);

    g_assert(!error_is_set(&errp));

    g_assert_cmpstr(res, ==, value);



    g_free(res);

}



static void test_visitor_in_enum(TestInputVisitorData *data,

                                 const void *unused)

{

    Error *errp = NULL;

    Visitor *v;

    EnumOne i;



    for (i = 0; EnumOne_lookup[i]; i++) {

        EnumOne res = -1;



        v = visitor_input_test_init(data, EnumOne_lookup[i]);



        visit_type_EnumOne(v, &res, NULL, &errp);

        g_assert(!error_is_set(&errp));

        g_assert_cmpint(i, ==, res);



        visitor_input_teardown(data, NULL);

    }



    data->siv = NULL;

}



static void input_visitor_test_add(const char *testpath,

                                   TestInputVisitorData *data,

                                   void (*test_func)(TestInputVisitorData *data, const void *user_data))

{

    g_test_add(testpath, TestInputVisitorData, data, NULL, test_func,

               visitor_input_teardown);

}



int main(int argc, char **argv)

{

    TestInputVisitorData in_visitor_data;



    g_test_init(&argc, &argv, NULL);



    input_visitor_test_add("/string-visitor/input/int",

                           &in_visitor_data, test_visitor_in_int);

    input_visitor_test_add("/string-visitor/input/bool",

                           &in_visitor_data, test_visitor_in_bool);

    input_visitor_test_add("/string-visitor/input/number",

                           &in_visitor_data, test_visitor_in_number);

    input_visitor_test_add("/string-visitor/input/string",

                            &in_visitor_data, test_visitor_in_string);

    input_visitor_test_add("/string-visitor/input/enum",

                            &in_visitor_data, test_visitor_in_enum);



    g_test_run();



    return 0;

}

test-string-output-visitor.c

0 → 100644
+188 −0
Original line number Diff line number Diff line 
/*

 * String Output Visitor unit-tests.

 *

 * Copyright (C) 2012 Red Hat Inc.

 *

 * Authors:

 *  Paolo Bonzini <pbonzini@redhat.com> (based on test-qmp-output-visitor)

 *

 * This work is licensed under the terms of the GNU GPL, version 2 or later.

 * See the COPYING file in the top-level directory.

 */



#include <glib.h>



#include "qapi/string-output-visitor.h"

#include "test-qapi-types.h"

#include "test-qapi-visit.h"

#include "qemu-objects.h"



typedef struct TestOutputVisitorData {

    StringOutputVisitor *sov;

    Visitor *ov;

} TestOutputVisitorData;



static void visitor_output_setup(TestOutputVisitorData *data,

                                 const void *unused)

{

    data->sov = string_output_visitor_new();

    g_assert(data->sov != NULL);



    data->ov = string_output_get_visitor(data->sov);

    g_assert(data->ov != NULL);

}



static void visitor_output_teardown(TestOutputVisitorData *data,

                                    const void *unused)

{

    string_output_visitor_cleanup(data->sov);

    data->sov = NULL;

    data->ov = NULL;

}



static void test_visitor_out_int(TestOutputVisitorData *data,

                                 const void *unused)

{

    int64_t value = -42;

    Error *errp = NULL;

    char *str;



    visit_type_int(data->ov, &value, NULL, &errp);

    g_assert(error_is_set(&errp) == 0);



    str = string_output_get_string(data->sov);

    g_assert(str != NULL);

    g_assert_cmpstr(str, ==, "-42");

    g_free(str);

}



static void test_visitor_out_bool(TestOutputVisitorData *data,

                                  const void *unused)

{

    Error *errp = NULL;

    bool value = true;

    char *str;



    visit_type_bool(data->ov, &value, NULL, &errp);

    g_assert(error_is_set(&errp) == 0);



    str = string_output_get_string(data->sov);

    g_assert(str != NULL);

    g_assert_cmpstr(str, ==, "true");

    g_free(str);

}



static void test_visitor_out_number(TestOutputVisitorData *data,

                                    const void *unused)

{

    double value = 3.14;

    Error *errp = NULL;

    char *str;



    visit_type_number(data->ov, &value, NULL, &errp);

    g_assert(error_is_set(&errp) == 0);



    str = string_output_get_string(data->sov);

    g_assert(str != NULL);

    g_assert_cmpstr(str, ==, "3.14");

    g_free(str);

}



static void test_visitor_out_string(TestOutputVisitorData *data,

                                    const void *unused)

{

    char *string = (char *) "Q E M U";

    Error *errp = NULL;

    char *str;



    visit_type_str(data->ov, &string, NULL, &errp);

    g_assert(error_is_set(&errp) == 0);



    str = string_output_get_string(data->sov);

    g_assert(str != NULL);

    g_assert_cmpstr(str, ==, string);

    g_free(str);

}



static void test_visitor_out_no_string(TestOutputVisitorData *data,

                                       const void *unused)

{

    char *string = NULL;

    Error *errp = NULL;

    char *str;



    /* A null string should return "" */

    visit_type_str(data->ov, &string, NULL, &errp);

    g_assert(error_is_set(&errp) == 0);



    str = string_output_get_string(data->sov);

    g_assert(str != NULL);

    g_assert_cmpstr(str, ==, "");

    g_free(str);

}



static void test_visitor_out_enum(TestOutputVisitorData *data,

                                  const void *unused)

{

    Error *errp = NULL;

    char *str;

    EnumOne i;



    for (i = 0; i < ENUM_ONE_MAX; i++) {

        visit_type_EnumOne(data->ov, &i, "unused", &errp);

        g_assert(!error_is_set(&errp));



        str = string_output_get_string(data->sov);

        g_assert(str != NULL);

        g_assert_cmpstr(str, ==, EnumOne_lookup[i]);

	g_free(str);

    }

}



static void test_visitor_out_enum_errors(TestOutputVisitorData *data,

                                         const void *unused)

{

    EnumOne i, bad_values[] = { ENUM_ONE_MAX, -1 };

    Error *errp;



    for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) {

        errp = NULL;

        visit_type_EnumOne(data->ov, &bad_values[i], "unused", &errp);

        g_assert(error_is_set(&errp) == true);

        error_free(errp);

    }

}



static void output_visitor_test_add(const char *testpath,

                                    TestOutputVisitorData *data,

                                    void (*test_func)(TestOutputVisitorData *data, const void *user_data))

{

    g_test_add(testpath, TestOutputVisitorData, data, visitor_output_setup,

               test_func, visitor_output_teardown);

}



int main(int argc, char **argv)

{

    TestOutputVisitorData out_visitor_data;



    g_test_init(&argc, &argv, NULL);



    output_visitor_test_add("/string-visitor/output/int",

                            &out_visitor_data, test_visitor_out_int);

    output_visitor_test_add("/string-visitor/output/bool",

                            &out_visitor_data, test_visitor_out_bool);

    output_visitor_test_add("/string-visitor/output/number",

                            &out_visitor_data, test_visitor_out_number);

    output_visitor_test_add("/string-visitor/output/string",

                            &out_visitor_data, test_visitor_out_string);

    output_visitor_test_add("/string-visitor/output/no-string",

                            &out_visitor_data, test_visitor_out_no_string);

    output_visitor_test_add("/string-visitor/output/enum",

                            &out_visitor_data, test_visitor_out_enum);

    output_visitor_test_add("/string-visitor/output/enum-errors",

                            &out_visitor_data, test_visitor_out_enum_errors);



    g_test_run();



    return 0;

}

tests/Makefile

+10 −2
Original line number Diff line number Diff line 
CHECKS = check-qdict check-qfloat check-qint check-qstring check-qlist

CHECKS += check-qjson test-qmp-output-visitor test-qmp-input-visitor

CHECKS += test-coroutine

CHECKS += test-string-input-visitor test-string-output-visitor test-coroutine



check-qint.o check-qstring.o check-qdict.o check-qlist.o check-qfloat.o check-qjson.o test-coroutine.o: $(GENERATED_HEADERS)
@@ -12,7 +12,9 @@ check-qfloat: check-qfloat.o qfloat.o $(tools-obj-y) 
check-qjson: check-qjson.o $(qobject-obj-y) $(tools-obj-y)

test-coroutine: test-coroutine.o qemu-timer-common.o async.o $(coroutine-obj-y) $(tools-obj-y)



test-qmp-input-visitor.o test-qmp-output-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir)

test-qmp-input-visitor.o test-qmp-output-visitor.o \

test-string-input-visitor.o test-string-output-visitor.o \

	test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir)



$(qapi-dir)/test-qapi-types.c $(qapi-dir)/test-qapi-types.h :\

$(SRC_PATH)/qapi-schema-test.json $(SRC_PATH)/scripts/qapi-types.py
@@ -25,6 +27,12 @@ $(SRC_PATH)/qapi-schema-test.json $(SRC_PATH)/scripts/qapi-commands.py 
	    $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-commands.py $(gen-out-type) -o "$(qapi-dir)" -p "test-" < $<, "  GEN   $@")





test-string-output-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y)

test-string-output-visitor: test-string-output-visitor.o $(qobject-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o



test-string-input-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y)

test-string-input-visitor: test-string-input-visitor.o $(qobject-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o



test-qmp-output-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y)

test-qmp-output-visitor: test-qmp-output-visitor.o $(qobject-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o