Commit 2c7ff933 authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Luiz Capitulino
Browse files

qapi: fail hard on stack imbalance 



QmpOutputVisitor will segfault if an imbalanced end function is
called.  So we can abort in QmpInputVisitor too.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
parent 3dcf71f6

qapi/qmp-input-visitor.c

+1 −4
Original line number Diff line number Diff line
@@ -77,11 +77,8 @@ static void qmp_input_push(QmpInputVisitor *qiv, const QObject *obj, Error **err 


static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp)

{

    assert(qiv->nb_stack > 0);

    qiv->nb_stack--;

    if (qiv->nb_stack < 0) {

        error_set(errp, QERR_BUFFER_OVERRUN);

        return;

    }

}



static void qmp_input_start_struct(Visitor *v, void **obj, const char *kind,