Commit 2c7d4427 authored by Richard Henderson's avatar Richard Henderson Committed by Peter Maydell
Browse files

decodetree: Fix comparison of Field 



Typo comparing the sign of the field, twice, instead of also comparing
the mask of the field (which itself encodes both position and length).

Reported-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 20190604154225.26992-1-richard.henderson@linaro.org
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent d67ebada

scripts/decodetree.py

+1 −1
Original line number Diff line number Diff line
@@ -184,7 +184,7 @@ class Field: 
        return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)



    def __eq__(self, other):

        return self.sign == other.sign and self.sign == other.sign

        return self.sign == other.sign and self.mask == other.mask



    def __ne__(self, other):

        return not self.__eq__(other)