Commit 2a4e2e49 authored Jul 26, 2017 by Philippe Mathieu-Daudé Committed by Michael Tokarev Jul 31, 2017

loader: check get_image_size() return value



since a negative value means it errored.

hw/core/loader.c:149:9: warning: Loss of sign in implicit conversion
    if (size > max_sz) {
        ^~~~
hw/core/loader.c:171:9: warning: Loss of sign in implicit conversion
    if (size > memory_region_size(mr)) {
        ^~~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

parent b94b330e

hw/core/loader.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -146,7 +146,7 @@ int load_image_targphys_as(const char *filename,
		int size;

		size = get_image_size(filename);
		if (size > max_sz) {
		if (size < 0 \|\| size > max_sz) {
		return -1;
		}
		if (size > 0) {
		@@ -168,7 +168,7 @@ int load_image_mr(const char filename, MemoryRegion mr)

		size = get_image_size(filename);

		if (size > memory_region_size(mr)) {
		if (size < 0 \|\| size > memory_region_size(mr)) {
		return -1;
		}
		if (size > 0) {