Commit 2a461c24 authored by Wei Yang's avatar Wei Yang Committed by Dr. David Alan Gilbert
Browse files

migration/postcopy: mis->have_listen_thread check will never be touched 



If mis->have_listen_thread is true, this means current PostcopyState
must be LISTENING or RUNNING. While the check at the beginning of the
function makes sure the state transaction happens when its previous
PostcopyState is ADVISE or DISCARD.

This means we would never touch this check.

Signed-off-by: default avatarWei Yang <richardw.yang@linux.intel.com>
Message-Id: <20191006000249.29926-2-richardw.yang@linux.intel.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent 4991f309

migration/savevm.c

+0 −5
Original line number Diff line number Diff line
@@ -1878,11 +1878,6 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis) 
        return -1;

    }



    if (mis->have_listen_thread) {

        error_report("CMD_POSTCOPY_RAM_LISTEN already has a listen thread");

        return -1;

    }



    mis->have_listen_thread = true;

    /* Start up the listening thread and wait for it to signal ready */

    qemu_sem_init(&mis->listen_thread_sem, 0);