Commit 29c6e6df authored by Alex Williamson's avatar Alex Williamson
Browse files

vfio-pci: Fix BAR size overflow 



We use an unsigned int when working with the PCI BAR size, which can
obviously overflow if the BAR is 4GB or larger.  This needs to change
to a fixed length uint64_t.  A similar issue is possible, though even
more unlikely, when mapping the region above an MSI-X table.  The
start of the MSI-X vector table must be below 4GB, but the end, and
therefore the start of the next mapping region, could still land at
4GB.

Suggested-by: default avatarNishank Trivedi <nishank.trivedi@netapp.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Reviewed-by: default avatarDon Slutz <dslutz@verizon.com>
Tested-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
parent 59a04198

hw/vfio/pci.c

+2 −2
Original line number Diff line number Diff line
@@ -2301,7 +2301,7 @@ static void vfio_unmap_bar(VFIOPCIDevice *vdev, int nr) 
static void vfio_map_bar(VFIOPCIDevice *vdev, int nr)

{

    VFIOBAR *bar = &vdev->bars[nr];

    unsigned size = bar->region.size;

    uint64_t size = bar->region.size;

    char name[64];

    uint32_t pci_bar;

    uint8_t type;
@@ -2351,7 +2351,7 @@ static void vfio_map_bar(VFIOPCIDevice *vdev, int nr) 
    }



    if (vdev->msix && vdev->msix->table_bar == nr) {

        unsigned start;

        uint64_t start;



        start = HOST_PAGE_ALIGN(vdev->msix->table_offset +

                                (vdev->msix->entries * PCI_MSIX_ENTRY_SIZE));