Commit 286690e3 authored Nov 06, 2013 by Paolo Bonzini Committed by Michael S. Tsirkin Dec 10, 2013

pc: s/INT64_MAX/UINT64_MAX/



It doesn't make sense for a region to be INT64_MAX in size:
memory core uses UINT64_MAX as a special value meaning
"all 64 bit" this is what was meant here.

While this should never affect the PC system which at the moment always
has < 63 bit size, this makes us hit all kind of corner case bugs with
sub-pages, so users are probably better off if we just use UINT64_MAX
instead.

Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent cf252e51

hw/i386/pc_piix.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -114,7 +114,7 @@ static void pc_init1(QEMUMachineInitArgs *args,

		if (pci_enabled) {
		pci_memory = g_new(MemoryRegion, 1);
		memory_region_init(pci_memory, NULL, "pci", INT64_MAX);
		memory_region_init(pci_memory, NULL, "pci", UINT64_MAX);
		rom_memory = pci_memory;
		} else {
		pci_memory = NULL;

hw/i386/pc_q35.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -101,7 +101,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
		/* pci enabled */
		if (pci_enabled) {
		pci_memory = g_new(MemoryRegion, 1);
		memory_region_init(pci_memory, NULL, "pci", INT64_MAX);
		memory_region_init(pci_memory, NULL, "pci", UINT64_MAX);
		rom_memory = pci_memory;
		} else {
		pci_memory = NULL;