Commit 27915efb authored by Andreas Färber's avatar Andreas Färber Committed by Anthony Liguori
Browse files

virtio-9p-device: Avoid freeing uninitialized memory 



In virtio_9p_device_init() there are 6x goto out that will lead to
v9fs_path_free() attempting to free unitialized path.data field.
Easiest way to trigger is: qemu-system-x86_64 -device virtio-9p-pci

Fix this by moving v9fs_path_init() before any goto out.

Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
Message-id: 1375315187-16534-1-git-send-email-afaerber@suse.de
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent d5a2bcf7

hw/9pfs/virtio-9p-device.c

+2 −1
Original line number Diff line number Diff line
@@ -61,6 +61,8 @@ static int virtio_9p_device_init(VirtIODevice *vdev) 


    s->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output);



    v9fs_path_init(&path);



    fse = get_fsdev_fsentry(s->fsconf.fsdev_id);



    if (!fse) {
@@ -111,7 +113,6 @@ static int virtio_9p_device_init(VirtIODevice *vdev) 
     * call back to do that. Since we are in the init path, we don't

     * use co-routines here.

     */

    v9fs_path_init(&path);

    if (s->ops->name_to_path(&s->ctx, NULL, "/", &path) < 0) {

        fprintf(stderr,

                "error in converting name to path %s", strerror(errno));