Commit 272545cf authored by Peter Maydell's avatar Peter Maydell Committed by Kevin Wolf
Browse files

block/qcow.c: Fix memory leak in qcow_create() 



Coverity points out that the code path in qcow_create() for
the magic "fat:" backing file name leaks the memory used to
store the filename (CID 1307771). Free the memory before
we overwrite the pointer.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent c3971b88

block/qcow.c

+1 −0
Original line number Diff line number Diff line
@@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts *opts, Error **errp) 
            header_size += backing_filename_len;

        } else {

            /* special backing file for vvfat */

            g_free(backing_file);

            backing_file = NULL;

        }

        header.cluster_bits = 9; /* 512 byte cluster to avoid copying