Commit 24f4d3d3 authored by Stefan Hajnoczi's avatar Stefan Hajnoczi
Browse files

tracetool: report error on foo() instead of foo(void)



C functions with no arguments must be declared foo(void) instead of
foo().  The tracetool argument list parser has never accepted an empty
argument list.  This patch adds a clear error message for this error
case.

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 20180110202553.31889-4-stefanha@redhat.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 6e497fa1
Loading
Loading
Loading
Loading
+2 −0
Original line number Original line Diff line number Diff line
@@ -75,6 +75,8 @@ class Arguments:
        res = []
        res = []
        for arg in arg_str.split(","):
        for arg in arg_str.split(","):
            arg = arg.strip()
            arg = arg.strip()
            if not arg:
                raise ValueError("Empty argument (did you forget to use 'void'?)")
            if arg == 'void':
            if arg == 'void':
                continue
                continue