Commit 242fbc19 authored by Sascha Silbe's avatar Sascha Silbe Committed by Max Reitz
Browse files

qemu-iotests: drop unused _within_tolerance() filter 



_within_tolerance() isn't used anymore and possibly creates temporary
files at predictable, world-writable locations. Get rid of it.

If it's needed again in the future it can be revived easily and fixed up
to use TEST_DIR and / or safely created temporary files.

Signed-off-by: default avatarSascha Silbe <silbe@linux.vnet.ibm.com>
Reviewed-by: default avatarBo Tu <tubo@linux.vnet.ibm.com>
Message-id: 1460472980-26319-2-git-send-email-silbe@linux.vnet.ibm.com
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 90c647db

tests/qemu-iotests/common.filter

+0 −101
Original line number Diff line number Diff line
@@ -19,107 +19,6 @@ 
# standard filters

#



# Checks that given_value is in range of correct_value +/- tolerance.

# Tolerance can be an absolute value or a percentage of the correct value

# (see examples with tolerances below).

# Outputs suitable message to stdout if it's not in range.

#

# A verbose option, -v, may be used as the LAST argument

#

# e.g.

# foo: 0.0298 = 0.03 +/- 5%

# _within_tolerance "foo" 0.0298 0.03 5%

#

# foo: 0.0298 = 0.03 +/- 0.01

# _within_tolerance "foo" 0.0298 0.03 0.01

#

# foo: 0.0298 = 0.03 -0.01 +0.002

# _within_tolerance "foo" 0.0298 0.03 0.01 0.002

#

# foo: verbose output of 0.0298 = 0.03 +/- 5%

# _within_tolerance "foo" 0.0298 0.03 5% -v

_within_tolerance()

{

  _name=$1

  _given_val=$2

  _correct_val=$3

  _mintol=$4

  _maxtol=$_mintol

  _verbose=0

  _debug=false



  # maxtol arg is optional

  # verbose arg is optional

  if [ $# -ge 5 ]

  then

     if [ "$5" = "-v" ]

     then

        _verbose=1

     else

        _maxtol=$5

     fi

  fi

  if [ $# -ge 6 ]

  then

     [ "$6" = "-v" ] && _verbose=1

  fi



  # find min with or without %

  _mintolerance=`echo $_mintol | sed -e 's/%//'`

  if [ $_mintol = $_mintolerance ]

  then

      _min=`echo "scale=5; $_correct_val-$_mintolerance" | bc`

  else

      _min=`echo "scale=5; $_correct_val-$_mintolerance*0.01*$_correct_val" | bc`

  fi



  # find max with or without %

  _maxtolerance=`echo $_maxtol | sed -e 's/%//'`

  if [ $_maxtol = $_maxtolerance ]

  then

      _max=`echo "scale=5; $_correct_val+$_maxtolerance" | bc`

  else

      _max=`echo "scale=5; $_correct_val+$_maxtolerance*0.01*$_correct_val" | bc`

  fi



  $_debug && echo "min = $_min"

  $_debug && echo "max = $_max"



  cat <<EOF >$tmp.bc.1

scale=5;

if ($_min <= $_given_val) 1;

if ($_min > $_given_val) 0;

EOF



  cat <<EOF >$tmp.bc.2

scale=5;

if ($_given_val <= $_max) 1;

if ($_given_val > $_max) 0;

EOF



  _above_min=`bc <$tmp.bc.1`

  _below_max=`bc <$tmp.bc.2`



  rm -f $tmp.bc.[12]



  _in_range=`expr $_above_min \& $_below_max`



  # fix up min, max precision for output

  # can vary for 5.3, 6.2

  _min=`echo $_min | sed -e 's/0*$//'` # get rid of trailling zeroes

  _max=`echo $_max | sed -e 's/0*$//'` # get rid of trailling zeroes



  if [ $_in_range -eq 1 ]

  then

        [ $_verbose -eq 1 ] && echo $_name is in range

        return 0

  else

        [ $_verbose -eq 1 ] && echo $_name has value of $_given_val

        [ $_verbose -eq 1 ] && echo $_name is NOT in range $_min .. $_max

        return 1

  fi

}



# ctime(3) dates

#

_filter_date()