Commit 2392ae6b authored by Bandan Das's avatar Bandan Das Committed by Gerd Hoffmann
Browse files

usb-mtp: Unconditionally check for the readonly bit 



Currently, it's only being checked if desc is NULL and
so write support breaks upon specifying desc

Signed-off-by: default avatarBandan Das <bsd@redhat.com>
Message-id: 20180503192028.14353-3-bsd@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 24e8d1fa

hw/usb/dev-mtp.c

+5 −4
Original line number Diff line number Diff line
@@ -1948,16 +1948,17 @@ static void usb_mtp_realize(USBDevice *dev, Error **errp) 
            return;

        }

        s->desc = strrchr(s->root, '/');

        /* Mark store as RW */

        if (!s->readonly) {

            s->flags |= (1 << MTP_FLAG_WRITABLE);

        }

        if (s->desc && s->desc[0]) {

            s->desc = g_strdup(s->desc + 1);

        } else {

            s->desc = g_strdup("none");

        }

    }

    /* Mark store as RW */

    if (!s->readonly) {

        s->flags |= (1 << MTP_FLAG_WRITABLE);

    }



}



static const VMStateDescription vmstate_usb_mtp = {