Commit 234779a2 authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x: s390_cpu_get_phys_page_debug has to return -1 



If translation fails, we have to return -1. For now, we
would simply return the value last stored to raddr (if any).

This way, reading invalid memory via gdb will return values, although it
shouldn't.

Reviewed-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: default avatarDavid Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
parent b3820e6c

target-s390x/helper.c

+3 −2
Original line number Diff line number Diff line
@@ -162,8 +162,9 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr vaddr) 
        vaddr &= 0x7fffffff;

    }



    mmu_translate(env, vaddr, MMU_INST_FETCH, asc, &raddr, &prot, false);



    if (mmu_translate(env, vaddr, MMU_INST_FETCH, asc, &raddr, &prot, false)) {

        return -1;

    }

    return raddr;

}