Commit 227ccf6b authored Sep 01, 2012 by Stefan Weil Committed by Luiz Capitulino Sep 05, 2012

qapi: Fix potential NULL pointer segfault



Report from smatch:

qapi-visit.c:1640 visit_type_BlockdevAction(8) error:
 we previously assumed 'obj' could be null (see line 1639)
qapi-visit.c:2432 visit_type_NetClientOptions(8) error:
 we previously assumed 'obj' could be null (see line 2431)

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

parent e4c8f004

scripts/qapi-visit.py

+1 −1

Original line number	Diff line number	Diff line
		@@ -157,7 +157,7 @@ void visit_type_%(name)s(Visitor m, %(name)s * obj, const char name, Error *
		if (!error_is_set(errp)) {
		visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), &err);
		if (!err) {
		if (!obj \|\| *obj) {
		if (obj && *obj) {
		visit_type_%(name)sKind(m, &(*obj)->kind, "type", &err);
		if (!err) {
		switch ((*obj)->kind) {