Commit 1f98e553 authored by Thomas Huth's avatar Thomas Huth Committed by David Gibson
Browse files

hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device 



QEMU currently aborts unexpectedly when the user tries to add and
remove a "spapr-tce-table" device:

$ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio
QEMU 2.9.92 monitor - type 'help' for more information
(qemu) device_add spapr-tce-table,id=x
(qemu) device_del x
**
ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted (core dumped)

The device should not be accessable for the users at all, it's just
used internally, so mark it with user_creatable = false.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 8ccccff9

hw/ppc/spapr_iommu.c

+2 −0
Original line number Diff line number Diff line
@@ -618,6 +618,8 @@ static void spapr_tce_table_class_init(ObjectClass *klass, void *data) 
    dc->init = spapr_tce_table_realize;

    dc->reset = spapr_tce_reset;

    dc->unrealize = spapr_tce_table_unrealize;

    /* Reason: This is just an internal device for handling the hypercalls */

    dc->user_creatable = false;



    QLIST_INIT(&spapr_tce_tables);