Commit 1be344b7 authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

ehci: fix queue->dev null ptr dereference 



In case we don't have a device for an active queue, just skip
processing the queue (same we do for inactive queues) and log
a guest bug.

Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Message-id: 20190821085319.13711-1-kraxel@redhat.com
parent 73f46fef

hw/usb/hcd-ehci.c

+3 −0
Original line number Diff line number Diff line
@@ -1838,6 +1838,9 @@ static int ehci_state_fetchqtd(EHCIQueue *q) 
            ehci_set_state(q->ehci, q->async, EST_EXECUTING);

            break;

        }

    } else if (q->dev == NULL) {

        ehci_trace_guest_bug(q->ehci, "no device attached to queue");

        ehci_set_state(q->ehci, q->async, EST_HORIZONTALQH);

    } else {

        p = ehci_alloc_packet(q);

        p->qtdaddr = q->qtdaddr;