Commit 1bbd6272 authored by Peter Maydell's avatar Peter Maydell Committed by David Gibson
Browse files

hw/ppc/mac_newworld: Free openpic_irqs array after use 



In ppc_core99_init(), we allocate an openpic_irqs array, which
we then use to collect up the various qemu_irqs which we're
going to connect to the interrupt controller. Once we've
called sysbus_connect_irq() to connect them all up, the
array is no longer required, but we forgot to free it.

Since board init is only run once at startup, the memory
leak is not a significant one.

Spotted by Coverity: CID 1192916.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 0c2adc17

hw/ppc/mac_newworld.c

+1 −0
Original line number Diff line number Diff line
@@ -303,6 +303,7 @@ static void ppc_core99_init(MachineState *machine) 
            sysbus_connect_irq(s, k++, openpic_irqs[i][j]);

        }

    }

    g_free(openpic_irqs);



    if (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) {

        /* 970 gets a U3 bus */