Commit 1bbd1592 authored by Markus Armbruster's avatar Markus Armbruster Committed by Anthony Liguori
Browse files

os-posix: Plug fd leak in qemu_create_pidfile() 



Spotted by Coverity.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 095ed5be

os-posix.c

+3 −0
Original line number Diff line number Diff line
@@ -372,13 +372,16 @@ int qemu_create_pidfile(const char *filename) 
        return -1;

    }

    if (lockf(fd, F_TLOCK, 0) == -1) {

        close(fd);

        return -1;

    }

    len = snprintf(buffer, sizeof(buffer), FMT_pid "\n", getpid());

    if (write(fd, buffer, len) != len) {

        close(fd);

        return -1;

    }



    close(fd);

    return 0;

}