Commit 1a89b608 authored by Nickolai Zeldovich's avatar Nickolai Zeldovich Committed by Jan Kiszka
Browse files

slirp: Don't crash on packets from 0.0.0.0/8. 



LWIP can generate packets with a source of 0.0.0.0, which triggers an
assertion failure in arp_table_add().  Instead of crashing, simply return
to avoid adding an invalid ARP table entry.

Signed-off-by: default avatarNickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
parent ce34cf72

slirp/arp_table.c

+3 −1
Original line number Diff line number Diff line
@@ -38,7 +38,9 @@ void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN]) 
                ethaddr[3], ethaddr[4], ethaddr[5]));



    /* Check 0.0.0.0/8 invalid source-only addresses */

    assert((ip_addr & htonl(~(0xf << 28))) != 0);

    if ((ip_addr & htonl(~(0xf << 28))) == 0) {

        return;

    }



    if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) {

        /* Do not register broadcast addresses */