Commit 1a423896 authored by Pavel Dovgalyuk's avatar Pavel Dovgalyuk Committed by Paolo Bonzini
Browse files

replay: don't destroy mutex at exit 



Replay mutex is held by vCPU thread and destroy function is called
from atexit of the main thread. Therefore we cannot destroy it safely.

Signed-off-by: default avatarPavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-Id: <20180227095254.1060.96971.stgit@pasha-VirtualBox>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarPavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
parent a36544d3

replay/replay-internal.c

+0 −5
Original line number Diff line number Diff line
@@ -176,11 +176,6 @@ void replay_mutex_init(void) 
    qemu_mutex_init(&lock);

}



void replay_mutex_destroy(void)

{

    qemu_mutex_destroy(&lock);

}



bool replay_mutex_locked(void)

{

    return replay_locked;

replay/replay-internal.h

+0 −1
Original line number Diff line number Diff line
@@ -104,7 +104,6 @@ void replay_get_array_alloc(uint8_t **buf, size_t *size); 
 * synchronisation between vCPU and main-loop threads. */



void replay_mutex_init(void);

void replay_mutex_destroy(void);

bool replay_mutex_locked(void);



/*! Checks error status of the file. */

replay/replay.c

+0 −1
Original line number Diff line number Diff line
@@ -358,7 +358,6 @@ void replay_finish(void) 
    replay_snapshot = NULL;



    replay_finish_events();

    replay_mutex_destroy();

}



void replay_add_blocker(Error *reason)