Commit 1a37e312 authored by Max Reitz's avatar Max Reitz Committed by Kevin Wolf
Browse files

vpc: Return 0 from vpc_co_create() on success 



blockdev_create_run() directly uses .bdrv_co_create()'s return value as
the job's return value.  Jobs must return 0 on success, not just any
nonnegative value.  Therefore, using blockdev-create for VPC images may
currently fail as the vpc driver may return a positive integer.

Because there is no point in returning a positive integer anywhere in
the block layer (all non-negative integers are generally treated as
complete success), we probably do not want to add more such cases.
Therefore, fix this problem by making the vpc driver always return 0 in
case of success.

Suggested-by: default avatarKevin Wolf <kwolf@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent effecce6

block/vpc.c

+2 −1
Original line number Diff line number Diff line
@@ -885,6 +885,7 @@ static int create_dynamic_disk(BlockBackend *blk, uint8_t *buf, 
        goto fail;

    }



    ret = 0;

 fail:

    return ret;

}
@@ -908,7 +909,7 @@ static int create_fixed_disk(BlockBackend *blk, uint8_t *buf, 
        return ret;

    }



    return ret;

    return 0;

}



static int calculate_rounded_image_size(BlockdevCreateOptionsVpc *vpc_opts,