Commit 198fd05c authored by Stefan Hajnoczi's avatar Stefan Hajnoczi Committed by Kevin Wolf
Browse files

dataplane: fix implicit IOThread refcount 



When creating an IOThread implicitly (the user did not specify
x-iothread=<id>) remember that iothread_find() does not return the
object with an incremented refcount.

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarFam Zheng <famz@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 20fccb18

hw/block/dataplane/virtio-blk.c

+1 −1
Original line number Diff line number Diff line
@@ -393,7 +393,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, 
    if (blk->iothread) {

        s->internal_iothread = false;

        s->iothread = blk->iothread;

        object_ref(OBJECT(s->iothread));

    } else {

        /* Create per-device IOThread if none specified */

        Error *local_err = NULL;
@@ -408,6 +407,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, 
        s->iothread = iothread_find(vdev->name);

        assert(s->iothread);

    }

    object_ref(OBJECT(s->iothread));

    s->ctx = iothread_get_aio_context(s->iothread);



    /* Prevent block operations that conflict with data plane thread */