Commit 18f49881 authored by Peter Maydell's avatar Peter Maydell
Browse files

configure: Fix shell syntax to placate OpenBSD's pdksh 

Unfortunately the OpenBSD pdksh does not like brackets inside
the right part of a ${variable+word} parameter expansion:

  $ echo "${a+($b)}"
  ksh: ${a+($b)}": bad substitution

though both bash and dash accept them. In any case this line
was causing odd output in the case where nettle is not present:
  nettle    no ()

(because if nettle is not present then $nettle will be "no",
not a null string or unset).

Rewrite it to just use an if.

This bug was originally introduced in becaeb72 and was present
in the 2.4.0 release.

Fixes: https://bugs.launchpad.net/qemu/+bug/1525682


Reported-by: Dmitrij D. Czarkoff
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 1450105357-8516-1-git-send-email-peter.maydell@linaro.org
parent 67a70840

configure

+5 −1
Original line number Diff line number Diff line
@@ -4766,7 +4766,11 @@ echo "GTK GL support $gtk_gl" 
echo "GNUTLS support    $gnutls"

echo "GNUTLS hash       $gnutls_hash"

echo "libgcrypt         $gcrypt"

echo "nettle            $nettle ${nettle+($nettle_version)}"

if test "$nettle" = "yes"; then

    echo "nettle            $nettle ($nettle_version)"

else

    echo "nettle            $nettle"

fi

echo "libtasn1          $tasn1"

echo "VTE support       $vte"

echo "curses support    $curses"