Commit 1840326c authored by Cleber Rosa's avatar Cleber Rosa
Browse files

Acceptance test x86_cpu_model_versions: shutdown VMs 



This shuts down the VMs that won't be used any longer during the
remainder of the test.

It's debatable if the very last one should also be shutdown manually,
and my opinion is that it shouldn't because that's taken care by the
immediately following tearDown().

Signed-off-by: default avatarCleber Rosa <crosa@redhat.com>
Message-Id: <20190828193628.7687-2-crosa@redhat.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 20869f98

tests/acceptance/x86_cpu_model_versions.py

+7 −0
Original line number Diff line number Diff line
@@ -243,6 +243,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),

                         'pc-i440fx-4.1 + Cascadelake-Server should not have arch-capabilities')

        vm.shutdown()



        vm = self.get_vm()

        vm.add_args('-S')
@@ -251,6 +252,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),

                         'pc-i440fx-4.0 + Cascadelake-Server should not have arch-capabilities')

        vm.shutdown()



        # command line must override machine-type if CPU model is not versioned:

        vm = self.get_vm()
@@ -260,6 +262,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertTrue(get_cpu_prop(vm, 'arch-capabilities'),

                        'pc-i440fx-4.0 + Cascadelake-Server,+arch-capabilities should have arch-capabilities')

        vm.shutdown()



        vm = self.get_vm()

        vm.add_args('-S')
@@ -268,6 +271,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),

                         'pc-i440fx-4.1 + Cascadelake-Server,-arch-capabilities should not have arch-capabilities')

        vm.shutdown()



        # versioned CPU model overrides machine-type:

        vm = self.get_vm()
@@ -277,6 +281,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertFalse(get_cpu_prop(vm, 'arch-capabilities'),

                         'pc-i440fx-4.1 + Cascadelake-Server-v1 should not have arch-capabilities')

        vm.shutdown()



        vm = self.get_vm()

        vm.add_args('-S')
@@ -285,6 +290,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertTrue(get_cpu_prop(vm, 'arch-capabilities'),

                         'pc-i440fx-4.1 + Cascadelake-Server-v1 should have arch-capabilities')

        vm.shutdown()



        # command line must override machine-type and versioned CPU model:

        vm = self.get_vm()
@@ -294,6 +300,7 @@ class X86CPUModelAliases(avocado_qemu.Test): 
        vm.launch()

        self.assertTrue(get_cpu_prop(vm, 'arch-capabilities'),

                         'pc-i440fx-4.0 + Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities')

        vm.shutdown()



        vm = self.get_vm()

        vm.add_args('-S')