Commit 183e4281 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Markus Armbruster
Browse files

qapi: move RTC_CHANGE to the target schema 



A few targets don't emit RTC_CHANGE, we could restrict the event to
the tagets that do emit it.

Note: There is a lot more of events & commands that we could restrict
to capable targets, with the cost of some additional complexity, but
the benefit of added correctness and better introspection.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20190214152251.2073-19-armbru@redhat.com>
parent 9d7b7086

hw/ppc/spapr_rtc.c

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ 
#include "sysemu/sysemu.h"

#include "hw/ppc/spapr.h"

#include "qapi/error.h"

#include "qapi/qapi-events-misc.h"

#include "qapi/qapi-events-target.h"

#include "qemu/cutils.h"



void spapr_rtc_read(sPAPRRTCState *rtc, struct tm *tm, uint32_t *ns)

hw/timer/mc146818rtc.c

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ 
#include "hw/timer/mc146818rtc.h"

#include "qapi/error.h"

#include "qapi/qapi-commands-target.h"

#include "qapi/qapi-events-misc.h"

#include "qapi/qapi-events-target.h"

#include "qapi/visitor.h"

#include "exec/address-spaces.h"

qapi/misc.json

+0 −23
Original line number Diff line number Diff line
@@ -2876,29 +2876,6 @@ 
{ 'event': 'ACPI_DEVICE_OST',

     'data': { 'info': 'ACPIOSTInfo' } }



##

# @RTC_CHANGE:

#

# Emitted when the guest changes the RTC time.

#

# @offset: offset between base RTC clock (as specified by -rtc base), and

#          new RTC clock value. Note that value will be different depending

#          on clock chosen to drive RTC (specified by -rtc clock).

#

# Note: This event is rate-limited.

#

# Since: 0.13.0

#

# Example:

#

# <-   { "event": "RTC_CHANGE",

#        "data": { "offset": 78 },

#        "timestamp": { "seconds": 1267020223, "microseconds": 435656 } }

#

##

{ 'event': 'RTC_CHANGE',

  'data': { 'offset': 'int' } }



##

# @ReplayMode:

#

qapi/target.json

+23 −0
Original line number Diff line number Diff line
@@ -7,6 +7,29 @@ 


{ 'include': 'misc.json' }



##

# @RTC_CHANGE:

#

# Emitted when the guest changes the RTC time.

#

# @offset: offset between base RTC clock (as specified by -rtc base), and

#          new RTC clock value

#

# Note: This event is rate-limited.

#

# Since: 0.13.0

#

# Example:

#

# <-   { "event": "RTC_CHANGE",

#        "data": { "offset": 78 },

#        "timestamp": { "seconds": 1267020223, "microseconds": 435656 } }

#

##

{ 'event': 'RTC_CHANGE',

  'data': { 'offset': 'int' },

  'if': 'defined(TARGET_ALPHA) || defined(TARGET_ARM) || defined(TARGET_HPPA) || defined(TARGET_I386) || defined(TARGET_MIPS) || defined(TARGET_MIPS64) || defined(TARGET_MOXIE) || defined(TARGET_PPC) || defined(TARGET_PPC64) || defined(TARGET_S390X) || defined(TARGET_SH4) || defined(TARGET_SPARC)' }



##

# @rtc-reset-reinjection:

#