Commit 1813d330 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

hmp: Remove dead code in hmp_qemu_io() 



blk can never be NULL, drop the check. This fixes a Coverity warning.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
parent bb9f8dd0

hmp.c

+5 −9
Original line number Diff line number Diff line
@@ -1924,6 +1924,7 @@ void hmp_qemu_io(Monitor *mon, const QDict *qdict) 
{

    BlockBackend *blk;

    BlockBackend *local_blk = NULL;

    AioContext *aio_context;

    const char* device = qdict_get_str(qdict, "device");

    const char* command = qdict_get_str(qdict, "command");

    Error *err = NULL;
@@ -1939,17 +1940,12 @@ void hmp_qemu_io(Monitor *mon, const QDict *qdict) 
        }

    }



    if (blk) {

        AioContext *aio_context = blk_get_aio_context(blk);

    aio_context = blk_get_aio_context(blk);

    aio_context_acquire(aio_context);



    qemuio_command(blk, command);



    aio_context_release(aio_context);

    } else {

        error_set(&err, ERROR_CLASS_DEVICE_NOT_FOUND,

                  "Device '%s' not found", device);

    }



fail:

    blk_unref(local_blk);