Commit 17f30eae authored by Markus Armbruster's avatar Markus Armbruster
Browse files

vl: Fix error location of positional arguments 



We blame badness in positional arguments on the last option argument:

    $ qemu-system-x86_64 -vnc :1 bad.img
    qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory

I believe we've done this ever since we reported locations.  Fix it to

    qemu-system-x86_64: bad.img: Could not open 'bad.img': No such file or directory

Reported-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20190318183312.4684-1-armbru@redhat.com>
Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
parent d61d1a1f

vl.c

+1 −0
Original line number Diff line number Diff line
@@ -3119,6 +3119,7 @@ int main(int argc, char **argv, char **envp) 
        if (optind >= argc)

            break;

        if (argv[optind][0] != '-') {

            loc_set_cmdline(argv, optind, 1);

            drive_add(IF_DEFAULT, 0, argv[optind++], HD_OPTS);

        } else {

            const QEMUOption *popt;