Commit 1789f4e3 authored by Halil Pasic's avatar Halil Pasic Committed by Cornelia Huck
Browse files

virtio-ccw: fix sanity check for vector 

The commit 8dfbaa6a ("virtio-ccw: introduce ccw specific queue limit")
did not touch the sanity check for the vector argument of the method
virtio_ccw_notify, despite intended as seen from
https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02705.html


To be able to scale number of virtqueues using the constant this sanity
check needs to be altered.

Fixes: 8dfbaa6a ("virtio-ccw: introduce ccw specific queue limit")
Reviewed-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: default avatarHalil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
parent cf87e0a3

hw/s390x/virtio-ccw.c

+2 −1
Original line number Diff line number Diff line
@@ -1177,7 +1177,8 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t vector) 
    SubchDev *sch = dev->sch;

    uint64_t indicators;



    if (vector >= 128) {

    /* queue indicators + secondary indicators */

    if (vector >= VIRTIO_CCW_QUEUE_MAX + 64) {

        return;

    }