Commit 158b9aa5 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Eric Blake
Browse files

nbd: fix memory leak in nbd_opt_go() 



nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf'

Reported-by: Clang Static Analyzer
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <20170727024224.22900-5-f4bug@amsat.org>
[introduced in commit 8ecaeae8]
Signed-off-by: default avatarEric Blake <eblake@redhat.com>
parent 3aabfec2

nbd/client.c

+5 −3
Original line number Diff line number Diff line
@@ -376,9 +376,11 @@ static int nbd_opt_go(QIOChannel *ioc, const char *wantname, 
    if (info->request_sizes) {

        stw_be_p(buf + 4 + len + 2, NBD_INFO_BLOCK_SIZE);

    }

    if (nbd_send_option_request(ioc, NBD_OPT_GO,

                                4 + len + 2 + 2 * info->request_sizes, buf,

                                errp) < 0) {

    error = nbd_send_option_request(ioc, NBD_OPT_GO,

                                    4 + len + 2 + 2 * info->request_sizes,

                                    buf, errp);

    g_free(buf);

    if (error < 0) {

        return -1;

    }