Commit 156778a0 authored by Babu Moger's avatar Babu Moger Committed by Eduardo Habkost
Browse files

hw/i386: Remove unnecessary initialization in x86_cpu_new 



The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
So, remove the initialization here.

Suggested-by: default avatarIgor Mammedov <imammedo@redhat.com>
Signed-off-by: default avatarBabu Moger <babu.moger@amd.com>
Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Message-Id: <158396719336.58170.11951852360759449871.stgit@naples-babu.amd.com>
parent 8cb30e3a

hw/i386/x86.c

+0 −4
Original line number Diff line number Diff line
@@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_id, Error **errp) 
{

    Object *cpu = NULL;

    Error *local_err = NULL;

    CPUX86State *env = NULL;



    cpu = object_new(MACHINE(x86ms)->cpu_type);



    env = &X86_CPU(cpu)->env;

    env->nr_dies = x86ms->smp_dies;



    object_property_set_uint(cpu, apic_id, "apic-id", &local_err);

    object_property_set_bool(cpu, true, "realized", &local_err);