Commit 1562047c authored Jul 12, 2016 by Kevin Wolf

block jobs: Improve error message for missing job ID



If a block job is started with a node name rather than a device name and
no explicit job ID is passed, it was reported that '' isn't a
well-formed ID. Which is correct, but we can make the message a little
bit nicer.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

parent 1b7f01d9

blockjob.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -132,6 +132,10 @@ void block_job_create(const char job_id, const BlockJobDriver *driver,

		if (job_id == NULL) {
		job_id = bdrv_get_device_name(bs);
		if (!*job_id) {
		error_setg(errp, "An explicit job ID is required for this node");
		return NULL;
		}
		}

		if (!id_wellformed(job_id)) {