Commit 150dcd1a authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

qemu-char, io: fix ordering of arguments for UDP socket creation 



Two wrongs make a right, but they should be fixed anyway.

Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-Id: <1455015557-15106-1-git-send-email-pbonzini@redhat.com>
parent c9a19d5b

io/channel-socket.c

+1 −1
Original line number Diff line number Diff line
@@ -258,7 +258,7 @@ int qio_channel_socket_dgram_sync(QIOChannelSocket *ioc, 
    int fd;



    trace_qio_channel_socket_dgram_sync(ioc, localAddr, remoteAddr);

    fd = socket_dgram(localAddr, remoteAddr, errp);

    fd = socket_dgram(remoteAddr, localAddr, errp);

    if (fd < 0) {

        trace_qio_channel_socket_dgram_fail(ioc);

        return -1;

qemu-char.c

+1 −1
Original line number Diff line number Diff line
@@ -4386,7 +4386,7 @@ static CharDriverState *qmp_chardev_open_udp(const char *id, 
    QIOChannelSocket *sioc = qio_channel_socket_new();



    if (qio_channel_socket_dgram_sync(sioc,

                                      udp->remote, udp->local,

                                      udp->local, udp->remote,

                                      errp) < 0) {

        object_unref(OBJECT(sioc));

        return NULL;