Commit 14542fea authored by Gleb Natapov's avatar Gleb Natapov Committed by Marcelo Tosatti
Browse files

kvm: remove guest triggerable abort() 



This abort() condition is easily triggerable by a guest if it configures
pci bar with unaligned address that overlaps main memory.

Signed-off-by: default avatarGleb Natapov <gleb@redhat.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent 70fedd76

kvm-all.c

+4 −12
Original line number Diff line number Diff line
@@ -432,18 +432,10 @@ static void kvm_set_phys_mem(target_phys_addr_t start_addr, 
    KVMSlot *mem, old;

    int err;



    if (start_addr & ~TARGET_PAGE_MASK) {

        if (flags >= IO_MEM_UNASSIGNED) {

            if (!kvm_lookup_overlapping_slot(s, start_addr,

                                             start_addr + size)) {

                return;

            }

            fprintf(stderr, "Unaligned split of a KVM memory slot\n");

        } else {

            fprintf(stderr, "Only page-aligned memory slots supported\n");

        }

        abort();

    }

    /* kvm works in page size chunks, but the function may be called

       with sub-page size and unaligned start address. */

    size = TARGET_PAGE_ALIGN(size);

    start_addr = TARGET_PAGE_ALIGN(start_addr);



    /* KVM does not support read-only slots */

    phys_offset &= ~IO_MEM_ROM;