Commit 141b1974 authored by Prasad J Pandit's avatar Prasad J Pandit Committed by Michael Roth
Browse files

qga: check bytes count read by guest-file-read 



While reading file content via 'guest-file-read' command,
'qmp_guest_file_read' routine allocates buffer of count+1
bytes. It could overflow for large values of 'count'.
Add check to avoid it.

Reported-by: default avatarFakhri Zulkifli <mohdfakhrizulkifli@gmail.com>
Signed-off-by: default avatarPrasad J Pandit <pjp@fedoraproject.org>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 65650f01

qga/commands-posix.c

+1 −1
Original line number Diff line number Diff line
@@ -458,7 +458,7 @@ struct GuestFileRead *qmp_guest_file_read(int64_t handle, bool has_count, 


    if (!has_count) {

        count = QGA_READ_COUNT_DEFAULT;

    } else if (count < 0) {

    } else if (count < 0 || count >= UINT32_MAX) {

        error_setg(errp, "value '%" PRId64 "' is invalid for argument count",

                   count);

        return NULL;

qga/commands-win32.c

+1 −1
Original line number Diff line number Diff line
@@ -318,7 +318,7 @@ GuestFileRead *qmp_guest_file_read(int64_t handle, bool has_count, 
    }

    if (!has_count) {

        count = QGA_READ_COUNT_DEFAULT;

    } else if (count < 0) {

    } else if (count < 0 || count >= UINT32_MAX) {

        error_setg(errp, "value '%" PRId64

                   "' is invalid for argument count", count);

        return NULL;