Commit 135b03cb authored Aug 08, 2019 by Alex Bennée

target/riscv: rationalise softfloat includes



We should avoid including the whole of softfloat headers in cpu.h and
explicitly include it only where we will be calling softfloat
functions. We can use the -types.h and -helpers.h in cpu.h for the few
bits that are global.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Palmer Dabbelt <palmer@sifive.com>

parent 502700d0

target/riscv/cpu.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -27,6 +27,7 @@
		#include "qemu/error-report.h"
		#include "hw/qdev-properties.h"
		#include "migration/vmstate.h"
		#include "fpu/softfloat-helpers.h"

		/* RISC-V CPU definitions */

target/riscv/cpu.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -22,7 +22,7 @@

		#include "qom/cpu.h"
		#include "exec/cpu-defs.h"
		#include "fpu/softfloat.h"
		#include "fpu/softfloat-types.h"

		#define TCG_GUEST_DEFAULT_MO 0

target/riscv/fpu_helper.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -21,6 +21,7 @@
		#include "qemu/host-utils.h"
		#include "exec/exec-all.h"
		#include "exec/helper-proto.h"
		#include "fpu/softfloat.h"

		target_ulong riscv_cpu_get_fflags(CPURISCVState *env)
		{