Commit 12dccfe4 authored by Peter Maydell's avatar Peter Maydell Committed by Samuel Thibault
Browse files

slirp: fork_exec(): Don't close() a negative number in fork_exec() 



In a fork_exec() error path we try to closesocket(s) when s might
be a negative number because the thing that failed was the
qemu_socket() call. Add a guard so we don't do this.

(Spotted by Coverity: CID 1005727 issue 1 of 2.)

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
parent e88718fc

slirp/misc.c

+3 −1
Original line number Diff line number Diff line
@@ -112,7 +112,9 @@ fork_exec(struct socket *so, const char *ex, int do_pty) 
		    bind(s, (struct sockaddr *)&addr, addrlen) < 0 ||

		    listen(s, 1) < 0) {

			error_report("Error: inet socket: %s", strerror(errno));

			if (s >= 0) {

			    closesocket(s);

			}



			return 0;

		}